As I suspected, we fix warnings on non-contrib code. These are only used on contrib code. -M
mmacy@anarchy [~/devel/upstream|9:46|26] find sys | xargs grep NO_WSELF_ASSIGN sys/modules/ipfilter/Makefile:CWARNFLAGS.fil.c= ${NO_WSELF_ASSIGN} -Wno-unused sys/modules/ipfilter/Makefile:CWARNFLAGS.ip_lookup.c= ${NO_WSELF_ASSIGN} -Wno-unused sys/modules/ipfilter/Makefile:CWARNFLAGS.ip_proxy.c= ${NO_WSELF_ASSIGN} -Wno-unused sys/conf/kern.mk:NO_WSELF_ASSIGN= -Wno-self-assign sys/conf/files: compile-with "${NORMAL_C} ${NO_WSELF_ASSIGN} -Wno-unused -I$S/contrib/ipfilter" sys/conf/files: compile-with "${NORMAL_C} ${NO_WSELF_ASSIGN} -Wno-unused -I$S/contrib/ipfilter" sys/conf/files: compile-with "${NORMAL_C} ${NO_WSELF_ASSIGN} -Wno-unused -Wno-error -I$S/contrib/ipfilter" mmacy@anarchy [~/devel/upstream|9:47|27] find sys | xargs grep NO_WSHIFT_COUNT_NEGATIVE sys/modules/ath_hal/Makefile:CWARNFLAGS.ah_regdomain.c= ${NO_WSHIFT_COUNT_NEGATIVE} ${NO_WSHIFT_COUNT_OVERFLOW} sys/conf/kern.mk:NO_WSHIFT_COUNT_NEGATIVE= -Wno-shift-count-negative sys/conf/files: compile-with "${NORMAL_C} ${NO_WSHIFT_COUNT_NEGATIVE} ${NO_WSHIFT_COUNT_OVERFLOW} -I$S/dev/ath" mmacy@anarchy [~/devel/upstream|9:47|28] find sys | xargs grep NO_WSHIFT_COUNT_OVERFLOW sys/modules/ath_hal/Makefile:CWARNFLAGS.ah_regdomain.c= ${NO_WSHIFT_COUNT_NEGATIVE} ${NO_WSHIFT_COUNT_OVERFLOW} sys/conf/kern.mk:NO_WSHIFT_COUNT_OVERFLOW= -Wno-shift-count-overflow sys/conf/files: compile-with "${NORMAL_C} ${NO_WSHIFT_COUNT_NEGATIVE} ${NO_WSHIFT_COUNT_OVERFLOW} -I$S/dev/ath" On Sat, May 19, 2018 at 5:30 AM, Matthew Macy <mm...@freebsd.org> wrote: > Oops I’ll add a separate define for that > > On Sat, May 19, 2018 at 04:27 Ed Maste <ema...@freebsd.org> wrote: >> >> On 18 May 2018 at 20:04, Matt Macy <mm...@freebsd.org> wrote: >> > Author: mmacy >> > Date: Sat May 19 00:04:01 2018 >> > New Revision: 333819 >> > URL: https://svnweb.freebsd.org/changeset/base/333819 >> > >> > Log: >> > Silence non-actionable warnings in vendor code >> ... >> > Modified: head/sys/conf/kern.mk >> > >> > ============================================================================== >> > --- head/sys/conf/kern.mk Fri May 18 23:42:08 2018 >> > (r333818) >> > +++ head/sys/conf/kern.mk Sat May 19 00:04:01 2018 >> > (r333819) >> > @@ -18,12 +18,13 @@ CWARNFLAGS?= -Wall -Wredundant-decls >> > -Wnested-externs >> > # a false positive. >> > .if ${COMPILER_TYPE} == "clang" >> > NO_WCONSTANT_CONVERSION= -Wno-error-constant-conversion >> > -NO_WSHIFT_COUNT_NEGATIVE= -Wno-error-shift-count-negative >> > -NO_WSHIFT_COUNT_OVERFLOW= -Wno-error-shift-count-overflow >> > -NO_WSELF_ASSIGN= -Wno-error-self-assign >> > +NO_WSHIFT_COUNT_NEGATIVE= -Wno-shift-count-negative >> > +NO_WSHIFT_COUNT_OVERFLOW= -Wno-shift-count-overflow >> > +NO_WSELF_ASSIGN= -Wno-self-assign >> >> This silences the warning across the tree, not just vendor code. _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"