On Sat, May 19, 2018 at 8:56 AM, Emmanuel Vadot <m...@bidouilliste.com> wrote: > On 2018-05-19 17:39, Matthew Macy wrote: >> >> On Sat, May 19, 2018 at 07:17 Emmanuel Vadot <m...@bidouilliste.com> >> wrote: >> >>> On 2018-05-19 15:35, Rodney W. Grimes wrote: >>>> >>>> [ Charset UTF-8 unsupported, converting... ] >>>>> >>>>> Author: mmacy >>>>> Date: Sat May 19 02:15:40 2018 >>>>> New Revision: 333822 >>>>> URL: https://svnweb.freebsd.org/changeset/base/333822 [1] >>>>> >>>>> >>>>> Log: >>>>> fix gcc8 unused variable and set but not used variable in unix >>> >>> >>>>> sockets >>>>> add copyright from lock rewrite while here >>>>> >>>>> Modified: >>>>> head/sys/kern/uipc_usrreq.c >>>>> >>>>> Modified: head/sys/kern/uipc_usrreq.c >>>>> >>> >> >> ============================================================================== >>>>> >>>>> --- head/sys/kern/uipc_usrreq.c Sat May 19 00:47:24 2018 >>> >>> (r333821) >>>>> >>>>> +++ head/sys/kern/uipc_usrreq.c Sat May 19 02:15:40 2018 >>> >>> (r333822) >>>>> >>>>> @@ -4,7 +4,7 @@ >>>>> * Copyright (c) 1982, 1986, 1989, 1991, 1993 >>>>> * The Regents of the University of California. >>>>> * Copyright (c) 2004-2009 Robert N. M. Watson >>>>> - * All rights reserved. >>>> >>>> >>>> Did you have permission from Robert Watson to remove this? >>>> >>>>> + * Copyright (c) 2018 Matthew Macy >>>>> * >>>>> * Redistribution and use in source and binary forms, with or >>> >>> without >>>>> >>>>> * modification, are permitted provided that the following >>> >>> conditions >>>> >>>> ... >>> >>> >>> That also seems a small patch to add your name in the copyright. >> >> >> Uhh... Locking rewrite was a small patch? Really? > > > Maybe I should I read the previous commits and the full log here :) sorry.
No problem. Thanks Warner for stepping up. I probably shouldn't respond before I've had my coffee. Just to be clear - I wasn't upset, just a bit flabbergasted. I clearly mentioned "locking rewrite" in the message and there were clearly no locking changes in this particular commit. The awake thing to do would have been to send a link to the commit itself and clarify that, although in pure line count was < 25%, it was a material change with substantial impact. https://svnweb.freebsd.org/base?view=revision&revision=333744 Cheers -M > >> >>> -- >>> Emmanuel Vadot <m...@bidouilliste.com> <m...@freebsd.org> >> >> >> >> Links: >> ------ >> [1] https://svnweb.freebsd.org/changeset/base/333822 > > > -- > Emmanuel Vadot <m...@bidouilliste.com> <m...@freebsd.org> _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
