On 6/13/2018 1:52 AM, Eitan Adler wrote: > Author: eadler > Date: Wed Jun 13 08:52:19 2018 > New Revision: 335042 > URL: https://svnweb.freebsd.org/changeset/base/335042 > > Log: > top(1): add myself to authors > > At this point I've mucked enough with top(1) that all bugs should be > blamed on me rather than William LeFebvre. >
Thank you for all of your work here... There's not exactly a guideline for this but I don't feel that non-functional changes qualify as "authors". Especially the sorting chosen. Perhaps I missed some rewrite you've done? Though none have 'Relnotes: yes' so I am assuming they were all non-functional. There's been 62 unique committers to usr.bin/top, which does not account for Submitted By. All of which are also missing from AUTHORS and Copyrights. I do see some people adding their Copyright on some commits but overall we haven't done that as a project and I am curious if we should change in that regard. Also I really abhor rewriting anything that's not broken as it causes merge conflict pain downstream and just adds regression risk. > Modified: > head/usr.bin/top/top.1 > head/usr.bin/top/utils.c > > Modified: head/usr.bin/top/top.1 > ============================================================================== > --- head/usr.bin/top/top.1 Wed Jun 13 08:52:17 2018 (r335041) > +++ head/usr.bin/top/top.1 Wed Jun 13 08:52:19 2018 (r335042) > @@ -360,6 +360,7 @@ process is waiting. > Lock names are prefixed with an asterisk \*(lq*\*(rq while sleep events > are not. > .Sh AUTHORS > +.An Eitan Adler Aq Mt ead...@freebsd.org > .An William LeFebvre, EECS Department, Northwestern University > .Sh BUGS > The command name for swapped processes should be tracked down, but this > > Modified: head/usr.bin/top/utils.c > ============================================================================== > --- head/usr.bin/top/utils.c Wed Jun 13 08:52:17 2018 (r335041) > +++ head/usr.bin/top/utils.c Wed Jun 13 08:52:19 2018 (r335042) > @@ -2,6 +2,7 @@ > * This program may be freely redistributed, > * but this entire comment MUST remain intact. > * > + * Copyright (c) 2018, Eitan Adler > * Copyright (c) 1984, 1989, William LeFebvre, Rice University > * Copyright (c) 1989, 1990, 1992, William LeFebvre, Northwestern University > * > -- Regards, Bryan Drewery
signature.asc
Description: OpenPGP digital signature
