In message <6d02404f-a7bb-01c7-3775-7a0349e30...@freebsd.org>, Bryan Drewery wr ites: > This is an OpenPGP/MIME signed message (RFC 4880 and 3156) > --nrEq6SIfsbZGYTgfSZ5R3mSN64FvoLCIQ > Content-Type: multipart/mixed; boundary="N66uQifSC1aSf1iMifRJdrqNP6RkoOJg1"; > protected-headers="v1" > From: Bryan Drewery <bdrew...@freebsd.org> > To: Cy Schubert <cy.schub...@cschubert.com> > Cc: src-committ...@freebsd.org, svn-src-all@freebsd.org, > svn-src-h...@freebsd.org > Message-ID: <6d02404f-a7bb-01c7-3775-7a0349e30...@freebsd.org> > Subject: Re: svn commit: r335906 - head/sys/conf > References: <201807031959.w63jxpa2069...@slippy.cwsent.com> > In-Reply-To: <201807031959.w63jxpa2069...@slippy.cwsent.com> > > --N66uQifSC1aSf1iMifRJdrqNP6RkoOJg1 > Content-Type: text/plain; charset=utf-8 > Content-Language: en-US > Content-Transfer-Encoding: quoted-printable > > On 7/3/2018 12:59 PM, Cy Schubert wrote: > > In message <201807031924.w63joi5w051...@repo.freebsd.org>, Bryan=20 > > Drewery writes > > : > >> Author: bdrewery > >> Date: Tue Jul 3 19:24:44 2018 > >> New Revision: 335906 > >> URL: https://svnweb.freebsd.org/changeset/base/335906 > >> > >> Log: > >> No need to make a copy to build genoffset_test.o > >> > >> Modified: > >> head/sys/conf/kern.post.mk > >> > >> Modified: head/sys/conf/kern.post.mk > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D > >> =3D > >> --- head/sys/conf/kern.post.mk Tue Jul 3 19:09:46 2018 (r33590 > >> 5) > >> +++ head/sys/conf/kern.post.mk Tue Jul 3 19:24:44 2018 (r33590 > >> 6) > >> @@ -191,14 +191,12 @@ offset.inc: $S/kern/genoffset.sh genoffset.o > >> genoffset.o: $S/kern/genoffset.c > >> ${CC} -c ${CFLAGS:N-flto:N-fno-common} $S/kern/genoffset.c > >> =20 > >> -genoffset_test.c: $S/kern/genoffset.c > >> - cp $S/kern/genoffset.c genoffset_test.c > >> - > >> # genoffset_test.o is not actually used for anything - the point of c= > ompilin > >> g it > >> # is to exercise the CTASSERT that checks that the offsets in the off= > set.inc > >> # _lite struct(s) match those in the original(s).=20 > >> -genoffset_test.o: genoffset_test.c offset.inc > >> - ${CC} -c ${CFLAGS:N-flto:N-fno-common} -DOFFSET_TEST genoffset_test.= > c > >> +genoffset_test.o: $S/kern/genoffset.c offset.inc > >> + ${CC} -c ${CFLAGS:N-flto:N-fno-common} -DOFFSET_TEST ${.ALLSRC:M*.c}= > \ > >> + -o ${.TARGET} > >=20 > > -o with -c in the previous line will cause an error. > > -o and -c are fine together. The problem is .ALLSRC duplicating sources > from the dependencies read from .depend.genoffset_test.o file. > Workaround in r335908.
gotcha. Sorry for the second spam. -- Cheers, Cy Schubert <cy.schub...@cschubert.com> FreeBSD UNIX: <c...@freebsd.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
