> On Thu, Mar 14, 2019 at 8:32 PM Rodney W. Grimes <free...@gndrsh.dnsmgr.net> > wrote: > > > > Author: chuck > > > Date: Fri Mar 15 02:11:28 2019 > > > New Revision: 345171 > > > URL: https://svnweb.freebsd.org/changeset/base/345171 > > > > > > Log: > > > Fix bhyve PCIe capability emulation > > > > > > PCIe devices starting with version 1.1 must set the Role-Based Error > > > Reporting bit. > > > > > > And while we're in the neighborhood, generalize the code assigning the > > > device type. > > > > > > Reviewed by: imp, araujo, rgrimes > > > Approved by: imp (mentor) > > > MFC after: 1 week > > > Differential Revision: https://reviews.freebsd.org/D19580 > > > > This code requires maintainer approval before a commit, > > though this was well reviewed that doesnt exclude it > > from the MAINTAINERS entry. > > > > Leave it for now, I am sure jhb or thyco are fine with it, > > this is just a heads up FYI for future commits. > > > > Bhyve code has been and still is under a fairly tight > > MAINTAINER status. > > > > There is no such thing as a hard lock in FreeBSD. This sounds like you are > advocating for that, but that's not the case. > > Stop this stupid nitpicking for single line commits. We don't have that > culture any more and it's really pissing a lot of people off. > > The MAINTAINERS file even says this: > > Please note that the content of this file is strictly advisory. > > And the entry for bhyve doesn't say things are mandatory, just requested. > > Jumping on people's case like this, for a review you yourself were on and > approved but made no mention of seeking further review / approval, is > demotivating and toxic. Please stop.
I explicitly DID add jhb to the review. I also explicitly did not mark the bhyve# box that is added by the hearald rules. I did not jump on him, I informed him of the entry, and told him to leave it. You how ever have infact jumped on me, repeatedly, if you want to talk about discouraging tones of behavior I suggest you look at yourself as well. > Warner > > > head/usr.sbin/bhyve/pci_emul.c > > > > > > Modified: head/usr.sbin/bhyve/pci_emul.c > > > > > ============================================================================== > > > --- head/usr.sbin/bhyve/pci_emul.c Fri Mar 15 02:11:27 2019 > > (r345170) > > > +++ head/usr.sbin/bhyve/pci_emul.c Fri Mar 15 02:11:28 2019 > > (r345171) > > > @@ -953,7 +953,10 @@ pci_emul_add_pciecap(struct pci_devinst *pi, int > > type) > > > bzero(&pciecap, sizeof(pciecap)); > > > > > > pciecap.capid = PCIY_EXPRESS; > > > - pciecap.pcie_capabilities = PCIECAP_VERSION | PCIEM_TYPE_ROOT_PORT; > > > + pciecap.pcie_capabilities = PCIECAP_VERSION | type; > > > + /* Devices starting with version 1.1 must set the RBER bit */ > > > + if (PCIECAP_VERSION >= 1) > > > + pciecap.dev_capabilities = PCIEM_CAP_ROLE_ERR_RPT; > > > pciecap.link_capabilities = 0x411; /* gen1, x1 */ > > > pciecap.link_status = 0x11; /* gen1, x1 */ > > > > > > > > > > > > > -- > > Rod Grimes > > rgri...@freebsd.org > > > > -- Rod Grimes rgri...@freebsd.org _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
