Author: kp
Date: Sat Mar 23 07:07:44 2019
New Revision: 345440
URL: https://svnweb.freebsd.org/changeset/base/345440
Log:
MFC r345223:
pf: Rename pfsync bucket lock
Previously the main pfsync lock and the bucket locks shared the same name.
This lead to spurious warnings from WITNESS like this:
acquiring duplicate lock of same type: "pfsync"
1st pfsync @ /usr/src/sys/netpfil/pf/if_pfsync.c:1402
2nd pfsync @ /usr/src/sys/netpfil/pf/if_pfsync.c:1429
It's perfectly okay to grab both the main pfsync lock and a bucket lock at the
same time.
We don't need different names for each bucket lock, because we should always
only acquire a single one of those at a time.
Modified:
stable/12/sys/netpfil/pf/if_pfsync.c
Directory Properties:
stable/12/ (props changed)
Modified: stable/12/sys/netpfil/pf/if_pfsync.c
==============================================================================
--- stable/12/sys/netpfil/pf/if_pfsync.c Sat Mar 23 07:07:41 2019
(r345439)
+++ stable/12/sys/netpfil/pf/if_pfsync.c Sat Mar 23 07:07:44 2019
(r345440)
@@ -363,7 +363,7 @@ pfsync_clone_create(struct if_clone *ifc, int unit, ca
M_PFSYNC, M_ZERO | M_WAITOK);
for (c = 0; c < pfsync_buckets; c++) {
b = &sc->sc_buckets[c];
- mtx_init(&b->b_mtx, pfsyncname, NULL, MTX_DEF);
+ mtx_init(&b->b_mtx, "pfsync bucket", NULL, MTX_DEF);
b->b_id = c;
b->b_sc = sc;
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
