On Mon, 4 Jan 2010, Luigi Rizzo wrote:
taking a random commit to this tree -- would you guys consider moving the
sctp sources to its own directory, e.g. netinet/sctp/ or something that
suits better ?
It would help to browse through the directory:
NAME FILES LINES
netinet/ 156 153k
sctp* 36 66k
tcp* 24 16k
ipfw/ 9 9k
I understand that some of the headers should remain in netinet/ but surely
the code is not bound to a specific place...
Keep in mind that every file rename invalidates outstanding patch sets against
those files maintained in our own branches, and at external vendors. I think
we should be cautious about gratuitous renaming, as it increases the work
factor both inside and outside the project significantly for relatively little
gain. Especially when the files already have a quite consistent naming scheme
that makes it easy to know which files belong to which component -- tcp_*,
sctp_*, udp_*, etc.
Robert N M Watson
Computer Laboratory
University of Cambridge
cheers
luigi
On Mon, Jan 04, 2010 at 06:25:38PM +0000, Michael Tuexen wrote:
Author: tuexen
Date: Mon Jan 4 18:25:38 2010
New Revision: 201523
URL: http://svn.freebsd.org/changeset/base/201523
Log:
Correct usage of parenthesis.
PR: kern/142066
Approved by: rrs (mentor)
Obtained from: Henning Petersen, Bruce Cran.
MFC after: 2 weeks
Modified:
head/sys/netinet/sctp_pcb.c
Modified: head/sys/netinet/sctp_pcb.c
==============================================================================
--- head/sys/netinet/sctp_pcb.c Mon Jan 4 18:21:27 2010 (r201522)
+++ head/sys/netinet/sctp_pcb.c Mon Jan 4 18:25:38 2010 (r201523)
@@ -5528,7 +5528,7 @@ sctp_pcb_init()
/* Init the TIMEWAIT list */
for (i = 0; i < SCTP_STACK_VTAG_HASH_SIZE; i++) {
- LIST_INIT(&SCTP_BASE_INFO(vtag_timewait[i]));
+ LIST_INIT(&SCTP_BASE_INFO(vtag_timewait)[i]);
}
#if defined(SCTP_USE_THREAD_BASED_ITERATOR)
@@ -6385,7 +6385,7 @@ sctp_is_vtag_good(struct sctp_inpcb *inp
}
skip_vtag_check:
- chain = &SCTP_BASE_INFO(vtag_timewait[(tag %
SCTP_STACK_VTAG_HASH_SIZE))];
+ chain = &SCTP_BASE_INFO(vtag_timewait)[(tag %
SCTP_STACK_VTAG_HASH_SIZE)];
/* Now what about timed wait ? */
if (!LIST_EMPTY(chain)) {
/*
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
