On 10/19/20 1:37 PM, Cy Schubert wrote:
> Author: cy
> Date: Mon Oct 19 20:37:38 2020
> New Revision: 366857
> URL: https://svnweb.freebsd.org/changeset/base/366857
> 
> Log:
>   Destroy cloned interfaces at netif stop, netif restart and shutdown.
>   This is especially important during shutdown because a child interface
>   of lagg with WOL enabled will not enable WOL at interface shutdown and
>   thus no WOL to wake up the device (and machine).
>   
>   PR:         158734, 109980
>   Reported by:        Antonio Huete Jimenez <tuxillo at quantumachine.net>
>               Marat N.Afanasyev <marat at zealot.ksu.ru>
>   reviewed by:        kp
>   MFC after:  1 week
>   Differential Revision:      https://reviews.freebsd.org/D26797

This causes some rather weird breakage for me.  Namely, after this
change, if I'm logged into a host via ssh and reboot it (via
shutdown -r now), I no longer get gracefully logged out by the
shutdown process as the network connections are all killed before
users are kicked off the system.  Instead, my ssh connection hangs
around forever until either it times out due to keep alives, or the
host in question reboots and send back a RST.

As I rather frequently use shutdown -r now or poweroff remotely via
ssh, I've found this rather annoying as I have to use ~. to recover
my shell again (and woe to me if it was a nested login and I forgot
to add enough extra ~'s to escape the N levels).

Probably if you only destroyed cloned interfaces during shutdown and
not all interfaces that would be a happy-enough compromise that
would still satisfy the original PR?

-- 
John Baldwin
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to