Author: kib
Date: Fri Apr  9 08:45:30 2010
New Revision: 206414
URL: http://svn.freebsd.org/changeset/base/206414

Log:
  MFC r206094:
  Supply default implementation of VOP_RENAME() that does neccessary
  unlocks and unreferences for argument vnodes, as expected by
  kern_renameat(9), and returns EOPNOTSUPP. This fixes locks and
  reference leaks when rename is attempted on fs that does not
  implement rename.

Modified:
  stable/8/sys/kern/vfs_default.c
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/amd64/include/xen/   (props changed)
  stable/8/sys/cddl/contrib/opensolaris/   (props changed)
  stable/8/sys/contrib/dev/acpica/   (props changed)
  stable/8/sys/contrib/pf/   (props changed)
  stable/8/sys/dev/xen/xenpci/   (props changed)

Modified: stable/8/sys/kern/vfs_default.c
==============================================================================
--- stable/8/sys/kern/vfs_default.c     Fri Apr  9 08:39:28 2010        
(r206413)
+++ stable/8/sys/kern/vfs_default.c     Fri Apr  9 08:45:30 2010        
(r206414)
@@ -67,6 +67,7 @@ __FBSDID("$FreeBSD$");
 #include <vm/vnode_pager.h>
 
 static int     vop_nolookup(struct vop_lookup_args *);
+static int     vop_norename(struct vop_rename_args *);
 static int     vop_nostrategy(struct vop_strategy_args *);
 static int     get_next_dirent(struct vnode *vp, struct dirent **dpp,
                                char *dirbuf, int dirbuflen, off_t *off,
@@ -113,6 +114,7 @@ struct vop_vector default_vnodeops = {
        .vop_poll =             vop_nopoll,
        .vop_putpages =         vop_stdputpages,
        .vop_readlink =         VOP_EINVAL,
+       .vop_rename =           vop_norename,
        .vop_revoke =           VOP_PANIC,
        .vop_strategy =         vop_nostrategy,
        .vop_unlock =           vop_stdunlock,
@@ -206,6 +208,20 @@ vop_nolookup(ap)
 }
 
 /*
+ * vop_norename:
+ *
+ * Handle unlock and reference counting for arguments of vop_rename
+ * for filesystems that do not implement rename operation.
+ */
+static int
+vop_norename(struct vop_rename_args *ap)
+{
+
+       vop_rename_fail(ap);
+       return (EOPNOTSUPP);
+}
+
+/*
  *     vop_nostrategy:
  *
  *     Strategy routine for VFS devices that have none.
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to