On Sun, Mar 13, 2011 at 6:15 AM, Alexander Leidinger <alexan...@leidinger.net> wrote: > On Sat, 12 Mar 2011 22:24:09 -0800 Artem Belevich <fbsdl...@src.cx> > wrote: > >> >> Modified: head/sys/i386/linux/syscalls.master >> >> - l_handler_t handler); } >> >> + void *handler); } >> > >> > What's wrong with l_handler_t? >> >> I don't recall the details, but I believe that the way l_handler_t is >> defined resulted in compilation errors in generated glue code. Glue >> generation code relies on '*' before the argument name in order to >> tell scalars from pointers. l_handler_t was interpreted as a scalar >> and on i386 where l_handler_t is a pointer, it produced compilation >> warning. > > What about documenting it with a comment nearby?
How about this: handle is l_handle_t, but the makesyscalls.sh relies on '*' to tell pointers from scalars when it generates DTrace glue code, so void* had to be used. I don't have commit bit, though. --Artem _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
