On Wed, 20 Apr 2011, Bjoern A. Zeeb wrote:
Author: bz
Date: Wed Apr 20 12:58:30 2011
New Revision: 220885
URL: http://svn.freebsd.org/changeset/base/220885
Log:
Compile in in_cksum* implementations for both IPv6 and IPv6.
IPv4 and IPv6 as Erwin noticed.
While in_pseudo() etc. is often used in offloading feature support,
in_cksum() is mostly used to fix some broken hardware.
Keeping both around for the moment allows us to compile NIC drivers
even in an IPv6 only environment without the need to mangle them
with #ifdef INETs in a way they are not prepared for. This will
leave some dead code paths that will not be exercised for IPv6.
Note that the changes coming soon removing the inet dependency from
drivers will break no-INET && no-INET6 (no-IP) kernels when those
drivers are included which is kind of a step backwards but we don't
have many people compiling no-IP kernels with the NIC drivers these
days (apart from my universe builds) I guess.
Sam had concerns about the inet dependency on drivers months back when
I added them and he was right. The real fix is really to add the
proper #ifdefs to the drivers in my view, in which cases i.e. TSO4
would not be announced or processed, etc. when there is no INET in the
kernel, etc.
But for all that to work and happen we'll need a better plan on how to
handle all these features rightish in the future. We have way too
much copy and paste in our drivers for all that.
I'll defer this discussion though for a bit later in the year.
Reviewed by: gnn
Sponsored by: The FreeBSD Foundation
Sponsored by: iXsystems
MFC after: 3 days
Modified:
head/sys/conf/files.amd64
head/sys/conf/files.arm
head/sys/conf/files.i386
head/sys/conf/files.ia64
head/sys/conf/files.mips
head/sys/conf/files.pc98
head/sys/conf/files.powerpc
head/sys/conf/files.sparc64
head/sys/conf/files.sun4v
--
Bjoern A. Zeeb You have to have visions!
Stop bit received. Insert coin for new address family.
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
