On 28 July 2011 06:59, Attilio Rao <atti...@freebsd.org> wrote: > I think that the following patch may better reflect the definition of size_t: > http://www.freebsd.org/~attilio/sintrcnt-fixup32.diff > > Do you think you can test it out?
Hi. FYI, I just finished buildtesting the patch with make universe. No stopping build errors found (surely, that still doesn't indicate that it works). > > 2011/7/25 Attilio Rao <atti...@freebsd.org>: >> Guys, I'm a bit out of that for a couple of days, flying to another >> continent, I'm not entirely sure the patch is right because I think we >> need an unified approach for specifying a 32-bits value, but you can >> check-in as a showstopper for the moment, I will make a better one in >> a couple of days. >> >> Attilio >> >> 2011/7/25 Nathan Whitehorn <nwhiteh...@freebsd.org>: >>> On 07/25/11 13:40, Andreas Tobler wrote: >>>> >>>> On 24.07.11 23:35, Nathan Whitehorn wrote: >>>>> >>>>> On 07/19/11 07:41, Attilio Rao wrote: >>>>>> >>>>>> Author: attilio >>>>>> Date: Tue Jul 19 12:41:57 2011 >>>>>> New Revision: 224216 >>>>>> URL: http://svn.freebsd.org/changeset/base/224216 >>>>>> >>>>>> Log: >>>>>> On 64 bit architectures size_t is 8 bytes, thus it should use an 8 bytes >>>>>> storage. >>>>>> Fix the sintrcnt/sintrnames specification. >>>>>> >>>>>> No MFC is previewed for this patch. >>>>>> >>>>> >>>>> These also need to be .long on 32-bit PowerPC, otherwise this change >>>>> triggers kernel panics and faults in sysctl. Please change it as quickly >>>>> as possible. >>>> >>>> Like the below? >>>> >>>> I'll test and I could commit if ok. (Build and approval) >>>> >>>> Gruss, >>>> Andreas >>>> >>>> Index: locore32.S >>>> =================================================================== >>>> --- locore32.S (revision 224326) >>>> +++ locore32.S (working copy) >>>> @@ -91,13 +91,13 @@ >>>> GLOBAL(intrnames) >>>> .space INTRCNT_COUNT * (MAXCOMLEN + 1) * 2 >>>> GLOBAL(sintrnames) >>>> - .word INTRCNT_COUNT * (MAXCOMLEN + 1) * 2 >>>> + .long INTRCNT_COUNT * (MAXCOMLEN + 1) * 2 >>>> >>>> .align 4 >>>> GLOBAL(intrcnt) >>>> .space INTRCNT_COUNT * 4 * 2 >>>> GLOBAL(sintrcnt) >>>> - .word INTRCNT_COUNT * 4 * 2 >>>> + .long INTRCNT_COUNT * 4 * 2 >>>> >>>> .text >>>> .globl btext >>> >>> Exactly like that. -- wbr, pluknet _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
