Author: rmacklem
Date: Sat Jul 30 22:57:38 2011
New Revision: 224532
URL: http://svn.freebsd.org/changeset/base/224532

Log:
  The new NFS client failed to vput() the new vnode if a setattr
  failed after the file was created in nfs_create(). This would
  probably only happen during a forced dismount. The old NFS client
  does have a vput() for this case. Detected by pho during recent
  testing, where an open syscall returned with a vnode still locked.
  
  Tested by:    pho
  Approved by:  re (kib)
  MFC after:    2 weeks

Modified:
  head/sys/fs/nfsclient/nfs_clvnops.c

Modified: head/sys/fs/nfsclient/nfs_clvnops.c
==============================================================================
--- head/sys/fs/nfsclient/nfs_clvnops.c Sat Jul 30 21:42:53 2011        
(r224531)
+++ head/sys/fs/nfsclient/nfs_clvnops.c Sat Jul 30 22:57:38 2011        
(r224532)
@@ -1596,6 +1596,8 @@ again:
                        if (attrflag)
                                (void) nfscl_loadattrcache(&newvp, &nfsva, NULL,
                                    NULL, 0, 1);
+                       if (error != 0)
+                               vput(newvp);
                }
        }
        if (!error) {
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to