On 05/04/2012 11:22 AM, Baptiste Daroussin wrote:
>>> > > fetch -s "${FETCHFILE}" >${SIZEFILE}
>>> > > SIZE="`cat ${SIZEFILE}`"
>>> > > - SIZE="`expr ${SIZE} / 1024`"
>>> > > + SIZE=$((SIZE/1024))
>> >
>> > Bug; should be '$SIZE/'
> No this is perfectly valid
Yes, that works, but it's not our usual style. However, the point is
moot as that whole block should be reduced down to:
SIZE=$(( `fetch -s "${FETCHFILE}"` / 1024 ))
If SIZEFILE is needed elsewhere that's a different matter, but as it is
that's a hot mess.
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
