On Tue, Jun 12, 2012 at 09:18:28PM +0200, Mateusz Guzik wrote: > On Tue, Jun 12, 2012 at 06:01:29PM +0200, Pawel Jakub Dawidek wrote: > > Look good and you can just add 'In co-operation with: pjd'. > > One minor thing is that fd_first_free() can return 'size' if there are > > no free slots available. Could you include that in the comment as well? > > > > http://people.freebsd.org/~mjg/patches/fdalloc%2bfd_first_free2.patch
Ok. Merge racct_set() call into one line, it now fits into 80 chars. I have no more objections. > > > fd_last_used has very same problem with comment as fd_first_free. This > > > function is static and the only caller always passes 0 as low. Given > > > that, how about the following: > > > http://people.freebsd.org/~mjg/patches/fd_last_used-cleanup.patch > > > > Looks good too. > > > > Updated in similar manner: > http://people.freebsd.org/~mjg/patches/fd_last_used-cleanup2.patch Ok. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl
pgpne5flCBgXY.pgp
Description: PGP signature
