"Alexander V. Chernikov" <melif...@freebsd.org> wrote in <4ffa894d.9050...@freebsd.org>:
me> On 09.07.2012 11:16, Hiroki Sato wrote: me> > Author: hrs me> > Date: Mon Jul 9 07:16:19 2012 me> > New Revision: 238277 me> > URL: http://svn.freebsd.org/changeset/base/238277 me> > me> > Log: me> > Make ipfw0 logging pseudo-interface clonable. It can be created me> > automatically me> > by $firewall_logif rc.conf(5) variable at boot time or manually by me> > ifconfig(8) me> > after a boot. me> > me> > Discussed on: freebsd-ipfw@ me> Em, well, I thought "discussed" means some kind of consensus? me> There was an alternative implementation proposed in -ipfw with no me> comments from you side. Additionally, there can be other (still not me> discussed) solutions like making this interface as loadable module me> (like pf do). I meant there was no strong objection. I am sorry for not commenting your implementation, but at least for ipfw0 it is difficult to decouple ifnet and bpf because the primary consumer is tcpdump(8), which depends on NET_RT_IFLIST to find the target. Probably your solution can be used for usbdump(8). The reason why I committed the patch now is there are reports that these pseudo interfaces made some applications confused and/or caused some performance degradation on 9.0R, and wanted to fix it in some way. I am still open for more sophisticated implementation and have no objection to replace mine with it. Do you have an idea about converting it with a loadable module? -- Hiroki
pgpRpchTh0luF.pgp
Description: PGP signature
