Thank you for the note Rick;
On 10/16/2012 08:36, Rick Macklem wrote:
Pedro F. Giffuni wrote:
Author: pfg
Date: Tue Oct 16 01:37:17 2012
New Revision: 241601
URL: http://svn.freebsd.org/changeset/base/241601
Log:
MFC r241143:
rpc: be sure to free cl_netid and cl_tp.
When creating a client with clnt_tli_create, it uses strdup to copy
strings for these fields if nconf is passed in. clnt_dg_destroy frees
these strings already. Make sure clnt_vc_destroy frees them in the
same
way.
I think the patch is fine. However, just fyi, there is no clnt_tli_create()
in the kernel and nothing in the kernel currently sets cl_netid or cl_tp
non-NULL, as
far as I can see.
The sys/ part is indeed there only to keep consistency with the libc
version from which it was derived.
According to OpenGrok though:
clnt_tli_create() is declared extern in sys/rpc/clnt.h and used in
lines 328 and 423 in sys/rpc/rpc_clnt.c. This can all be dead code
but JIC it seems good to keep the check.
Cheers,
Pedro.
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
