On 15 November 2012 14:22, Konstantin Belousov <kostik...@gmail.com> wrote: > On Thu, Nov 15, 2012 at 06:49:17PM +0000, Eitan Adler wrote: >> Author: eadler >> Date: Thu Nov 15 18:49:17 2012 >> New Revision: 243095 >> URL: http://svnweb.freebsd.org/changeset/base/243095 >> >> Log: >> Remove unneeded header from agp: opt_bus.h >> >> Tested with "make universe" > make universe cannot prove anything about usefulness of the removed include, > just because *_opt.h files contains only defines, which are used later > by the code like
This is a good point. In this case I had done the manual review as well. "make universe" was an additional check. > If you are removing the option include, the module Makefile should be > adjusted too. :-\ I had sent this to Colin but forgot to include it in my final commit. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
