On Sat, Dec 01, 2012 at 06:12:55PM +0000, Andriy Gapon wrote:
> Author: avg
> Date: Sat Dec  1 18:12:55 2012
> New Revision: 243762
> URL: http://svnweb.freebsd.org/changeset/base/243762
> 
> Log:
>   gfs_file_inactive: replace bad code with ugly code
>   
>   Also, make it explicit that V_XATTRDIR is not properly supported in gfs
>   code yet.
>   
>   The bad code was plain incorrect: (a) it spoiled handling of v_usecount
>   reaching zero and (b) it leaked v_holdcnt.
>   
>   The ugly code employs potentially unsafe locking tricks.
>   
>   Ideally we should separate vnode lifecycle and gfs node lifecycle.
>   A gfs node should have its own reference count where its child nodes
>   should be accounted.

Very good you are touching this:) If you verify if it works, you should
try .zfs/ directory when it is visible and not visible through local
file system and through NFS. All those cases have their own bugs in the
past.

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl

Attachment: pgpNWN1t8Sura.pgp
Description: PGP signature

Reply via email to