Author: trasz
Date: Mon Jul 28 21:14:41 2014
New Revision: 269197
URL: http://svnweb.freebsd.org/changeset/base/269197

Log:
  Fix potential double free that could happen after connection error.
  
  MFC after:    3 days

Modified:
  head/sys/dev/iscsi/icl.c

Modified: head/sys/dev/iscsi/icl.c
==============================================================================
--- head/sys/dev/iscsi/icl.c    Mon Jul 28 21:11:18 2014        (r269196)
+++ head/sys/dev/iscsi/icl.c    Mon Jul 28 21:14:41 2014        (r269197)
@@ -664,7 +664,10 @@ icl_conn_receive_pdu(struct icl_conn *ic
        }
 
        if (error != 0) {
-               icl_pdu_free(request);
+               /*
+                * Don't free the PDU; it's pointed to by ic->ic_receive_pdu
+                * and will get freed in icl_conn_close().
+                */
                icl_conn_fail(ic);
        }
 
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to