On Nov 15, 2014, at 21:26, Garrett Cooper <yaneurab...@gmail.com> wrote:
> On Nov 15, 2014, at 21:24, Alfred Perlstein <alf...@freebsd.org> wrote: > >> On 11/15/14, 9:22 PM, Garrett Cooper wrote: >>> On Nov 15, 2014, at 21:19, Alfred Perlstein <alf...@freebsd.org> wrote: >>> >>>> This looks easy enough to fix under _thr_find_thread() in libthread. >>>> >>>> Any interest in fixing it? >>> Yes, if it’s POSIXly correct and doesn’t break everything else. >>> >>>> Might be worth hacking _thr_find_thread() to take an ERRNO to return based >>>> on NULL until we chase down all the paths into it just in case EINVAL is a >>>> valid ptr. >>> K. Thanks for the hint! >>> >>>> Also, just wondering what happens on other platforms, does it elicit a >>>> crash? Ie. is NULL a safe value to pass in on other platforms? >>> I wish I knew what happened on !x86 platforms… I honestly don’t have access >>> to ARM/MIPS/PowerPC, so I can’t say :/. >>> >>> Thanks! >> >> Oh, I meant Linux and Solaris, or even other BSD. > > Ah, good question. pho@ ran some of the tests in contrib/netbsd-tests on > Linux/OSX before to do a side-by-side comparison, but I haven’t setup the > necessary environment to do that testing [yet]. FWIW, there’s some weirdness with one of the testcases that was never fully integrated in at Isilon where it blocks on a random mutex in libthr… trying to figure out what’s causing it to do that, but this might be related...
signature.asc
Description: Message signed with OpenPGP using GPGMail
