On Dec 31, 2014, at 7:54, Julio Merino <j...@meroh.net> wrote: > On Dec 30, 2014, at 21:46, Garrett Cooper <n...@freebsd.org> wrote: > >> Author: ngie >> Date: Tue Dec 30 20:46:01 2014 >> New Revision: 276423 >> URL: https://svnweb.freebsd.org/changeset/base/276423 >> >> Log: >> MFC r274077: >> >> As an optimization (in simple, well used cases) only call cat ${.ALLSRC} >> when >> generating files from various sources instead of calling cat ${.ALLSRC} | >> sed > > Is there any visible effect to this optimization? Otherwise, the extra > complexity does not seem warranted.
Hi Julio!
There are a few things to gain from this:
1. Errors with cat’ing the files are caught when sed transformations aren’t
applied to the files.
2. Less resources are used in generating the files if sed isn’t needed:
i. Less forked processes.
ii. No pipelines need to be created.
I don’t have numbers for how much faster it is (probably negligible if done
once, potentially more noticeable if done as a micro benchmark), but I could do
this if you like.
Thank you!
signature.asc
Description: Message signed with OpenPGP using GPGMail
