On Tue, 8 Jun 2010, John Baldwin wrote:

On Tuesday 08 June 2010 2:04:07 pm John Baldwin wrote:
Log:
  Move the machine check support code to the x86 tree since it is identical
  on i386 and amd64.

  Requested by: alc

It would be nice to consolidate <machine/mca.h> as that is identical on both
platforms, but that moving to x86/include is trickier as the header needs to
be available in userland, probably as <machine/mca.h> still.  <x86/mca.h>
would work ok (i.e. in /usr/include/x86/mca.h), but that makes things trickier
in the kernel as the file should really live in sys/x86/include, not sys/x86
directly.

Having x86/include would defeat <machine>.  However, <machine> is only
good for MD implentations of MI interfaces (things like PAGE_SIZE and
va_arg()), so mca.h, like many other headers now there, should never
have been in <machine>.  mca.h is very MD and currently only exists
for amd64, i386, ia64 and pc98.  Applications that know that there is
such a file can also know where it is.  It should be somewhere like
<x86> for amd64, i386 and pc98.  This is mainly for userland.  In the
kernel, the natural place for most arch-specific headers is in the
arch/arch subdir, not arch/include where they are now.  That would be
sys/x86/x86 here.  There seems to be no reason for the arch/include
subdir to exist for pseudo-arches like x86.  It would just be a little
easier to export only the headers in it if the headers are separate.

Bruce
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to