On Jul 23, 2010, at 15:27 , pluknet wrote: > On 23 July 2010 21:53, George V. Neville-Neil <[email protected]> wrote: >> Author: gnn >> Date: Fri Jul 23 17:53:39 2010 >> New Revision: 210428 >> URL: http://svn.freebsd.org/changeset/base/210428 >> >> Log: >> Fix a bug in the statistics code for tracking the head and >> tail pointers of the tx and rx queues. We needed a SYSCTL_PROC >> to correctly get the values at run time. >> >> Submitted by: Andrew Boyer aboyer at averesystems.com >> MFC after: 1 week >> >> Modified: >> head/sys/dev/e1000/if_igb.c >> >> Modified: head/sys/dev/e1000/if_igb.c >> ============================================================================== >> --- head/sys/dev/e1000/if_igb.c Fri Jul 23 17:44:01 2010 (r210427) >> +++ head/sys/dev/e1000/if_igb.c Fri Jul 23 17:53:39 2010 (r210428) >> @@ -4927,6 +4927,74 @@ igb_update_vf_stats_counters(struct adap >> } >> >> >> +/** igb_sysctl_tdh_handler - Handler function >> + * Retrieves the TDH value from the hardware >> + */ >> +static int igb_sysctl_tdh_handler(SYSCTL_HANDLER_ARGS) >> +{ > > ^^ > This function definition (and three ones below) breaks style(9): > " The function type should be on a line by itself preceding the function." >
Quite right, I've committed a style(9) fix. Thanks, George _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "[email protected]"
