On Fri, Oct 1, 2010 at 9:34 AM, Andriy Gapon <a...@freebsd.org> wrote: > Author: avg > Date: Fri Oct 1 09:34:41 2010 > New Revision: 213322 > URL: http://svn.freebsd.org/changeset/base/213322 > > Log: > sysctls in kern_shutdown: add twin tunables > > also make couple of sysctl-controlled variables static > > Reviewed by: rwatson > MFC after: 1 week > > Modified: > head/sys/kern/kern_shutdown.c > > Modified: head/sys/kern/kern_shutdown.c > ============================================================================== > --- head/sys/kern/kern_shutdown.c Fri Oct 1 09:18:30 2010 > (r213321) > +++ head/sys/kern/kern_shutdown.c Fri Oct 1 09:34:41 2010 > (r213322) > @@ -98,21 +98,24 @@ int debugger_on_panic = 0; > #else > int debugger_on_panic = 1; > #endif > -SYSCTL_INT(_debug, OID_AUTO, debugger_on_panic, CTLFLAG_RW, > +SYSCTL_INT(_debug, OID_AUTO, debugger_on_panic, CTLFLAG_RW | CTLFLAG_TUN, > &debugger_on_panic, 0, "Run debugger on kernel panic");
I thought CTLFLAG_TUN was only used to provide a more useful error message when writing to a read-only sysctl? I think the CTLFLAG_TUN should not be here for a RW sysctl. Thanks, matthew > +TUNABLE_INT("debug.debugger_on_panic", &debugger_on_panic); > > #ifdef KDB_TRACE > -int trace_on_panic = 1; > +static int trace_on_panic = 1; > #else > -int trace_on_panic = 0; > +static int trace_on_panic = 0; > #endif > -SYSCTL_INT(_debug, OID_AUTO, trace_on_panic, CTLFLAG_RW, > +SYSCTL_INT(_debug, OID_AUTO, trace_on_panic, CTLFLAG_RW | CTLFLAG_TUN, > &trace_on_panic, 0, "Print stack trace on kernel panic"); > +TUNABLE_INT("debug.trace_on_panic", &trace_on_panic); > #endif /* KDB */ > > -int sync_on_panic = 0; > -SYSCTL_INT(_kern, OID_AUTO, sync_on_panic, CTLFLAG_RW, > +static int sync_on_panic = 0; > +SYSCTL_INT(_kern, OID_AUTO, sync_on_panic, CTLFLAG_RW | CTLFLAG_TUN, > &sync_on_panic, 0, "Do a sync before rebooting from a panic"); > +TUNABLE_INT("kern.sync_on_panic", &sync_on_panic); > > SYSCTL_NODE(_kern, OID_AUTO, shutdown, CTLFLAG_RW, 0, "Shutdown > environment"); > > _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"