On 7 December 2010 11:21, Pawel Jakub Dawidek <p...@freebsd.org> wrote:

> PS. Do you know your change breaks all current ZFS installation if
> stripesize is defined for a provider?
>
>        # zpool create tank ada0
>        (upgrade FreeBSD so that ada0 now reports 4kB stripesize)
>        # zpool import tank
>        cannot import 'tank': invalid vdev configuration

Actually I did test the patch and, similar to the Solaris people,
found that ZFS records ashift in metadata and uses the recorded one
instead of hardcoded / detected one. What you found here really
shouldn't happen. Are you sure only stripesize was increased in your
case, not sectorsize?

> So you change was not only poorly thought out and not reviewed, but also
> not even minimally tested. Before we go any further, back it out.

This actually is the first problem that requires backing it out. I will do it.
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to