On Thu, Jul 5, 2018 at 8:54 AM, Konstantin Belousov <kostik...@gmail.com> wrote: > On Thu, Jul 05, 2018 at 07:56:22AM -0700, John Baldwin wrote: >> On 7/4/18 7:22 AM, Konstantin Belousov wrote: >> > On Tue, Jul 03, 2018 at 11:05:42PM +0000, Matt Macy wrote: >> >> Author: mmacy >> >> Date: Tue Jul 3 23:05:42 2018 >> >> New Revision: 335916 >> >> URL: https://svnweb.freebsd.org/changeset/base/335916 >> >> >> >> Log: >> >> Enable MODULE_TIED by default for modules compiled with the kernel >> > But why ? >> >> I think we should enable KLD_TIED to inline critical_* etc. for modules >> built as part of a kernel that are installed alongside the kernel in >> /boot/<kerneldir>. > >> I don't think we need to support modules built with kernel A loaded into >> kernel B. >> > This is the crusial point. I do not object, but this this is a radical > change from the previous mode of modules build. > > I do not want to put words in other person mouth, but I beliee that the > original intent of KLD_TIED/MODULE_TIED was much more limited. Only some > specific modules were to be tied.
My intention was only to allow it for select modules compiled _with_ the kernel. Then there was a heated discussion about documentation and how to communicate it's distinction with DECLARE_MODULE_TIED. In response to which John said (assuming I understood correctly, communication is hard) that it should be the default and specified doing it the way I did it. That seemed reasonable - but I don't have strong feelings one way or the other. I apologize if I misunderstood any guidance I was provided. -M _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"