svn commit: r338166 - head/sys/dev/cxgbe

[Navdeep Parhar]

Author: np
Date: Tue Aug 21 23:33:38 2018
New Revision: 338166
URL: https://svnweb.freebsd.org/changeset/base/338166

Log:
  cxgbe(4): Be explicit about ignoring the return value of cmpset in some
  cases.
  
  Reported by:  Coverity (CIDs 1009398, 1009400, 1009401, 1357325, 1394783).  
All false positives.
  Sponsored by: Chelsio Communications

Modified:
  head/sys/dev/cxgbe/t4_netmap.c
  head/sys/dev/cxgbe/t4_sge.c

Modified: head/sys/dev/cxgbe/t4_netmap.c
==============================================================================
--- head/sys/dev/cxgbe/t4_netmap.c      Tue Aug 21 23:12:46 2018        
(r338165)
+++ head/sys/dev/cxgbe/t4_netmap.c      Tue Aug 21 23:33:38 2018        
(r338166)
@@ -385,7 +385,7 @@ cxgbe_netmap_on(struct adapter *sc, struct vi_info *vi
                t4_write_reg(sc, sc->sge_kdoorbell_reg,
                    nm_rxq->fl_db_val | V_PIDX(j));
 
-               atomic_cmpset_int(&nm_rxq->nm_state, NM_OFF, NM_ON);
+               (void) atomic_cmpset_int(&nm_rxq->nm_state, NM_OFF, NM_ON);
        }
 
        for_each_nm_txq(vi, i, nm_txq) {

Modified: head/sys/dev/cxgbe/t4_sge.c
==============================================================================
--- head/sys/dev/cxgbe/t4_sge.c Tue Aug 21 23:12:46 2018        (r338165)
+++ head/sys/dev/cxgbe/t4_sge.c Tue Aug 21 23:33:38 2018        (r338166)
@@ -1383,7 +1383,7 @@ t4_intr_evt(void *arg)
 
        if (atomic_cmpset_int(&iq->state, IQS_IDLE, IQS_BUSY)) {
                service_iq(iq, 0);
-               atomic_cmpset_int(&iq->state, IQS_BUSY, IQS_IDLE);
+               (void) atomic_cmpset_int(&iq->state, IQS_BUSY, IQS_IDLE);
        }
 }
 
@@ -1397,7 +1397,7 @@ t4_intr(void *arg)
 
        if (atomic_cmpset_int(&iq->state, IQS_IDLE, IQS_BUSY)) {
                service_iq_fl(iq, 0);
-               atomic_cmpset_int(&iq->state, IQS_BUSY, IQS_IDLE);
+               (void) atomic_cmpset_int(&iq->state, IQS_BUSY, IQS_IDLE);
        }
 }
 
@@ -1412,7 +1412,7 @@ t4_nm_intr(void *arg)
 
        if (atomic_cmpset_int(&nm_rxq->nm_state, NM_ON, NM_BUSY)) {
                service_nm_rxq(nm_rxq);
-               atomic_cmpset_int(&nm_rxq->nm_state, NM_BUSY, NM_ON);
+               (void) atomic_cmpset_int(&nm_rxq->nm_state, NM_BUSY, NM_ON);
        }
 }
 
@@ -1498,7 +1498,7 @@ service_iq(struct sge_iq *iq, int budget)
                                if (atomic_cmpset_int(&q->state, IQS_IDLE,
                                    IQS_BUSY)) {
                                        if (service_iq_fl(q, q->qsize / 16) == 
0) {
-                                               atomic_cmpset_int(&q->state,
+                                               (void) 
atomic_cmpset_int(&q->state,
                                                    IQS_BUSY, IQS_IDLE);
                                        } else {
                                                STAILQ_INSERT_TAIL(&iql, q,
@@ -1546,7 +1546,7 @@ service_iq(struct sge_iq *iq, int budget)
                q = STAILQ_FIRST(&iql);
                STAILQ_REMOVE_HEAD(&iql, link);
                if (service_iq_fl(q, q->qsize / 8) == 0)
-                       atomic_cmpset_int(&q->state, IQS_BUSY, IQS_IDLE);
+                       (void) atomic_cmpset_int(&q->state, IQS_BUSY, IQS_IDLE);
                else
                        STAILQ_INSERT_TAIL(&iql, q, link);
        }
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"