On Mon, Apr 8, 2019, 2:35 AM Chris Rees <cr...@freebsd.org> wrote: > On 2019-04-08 08:57, Oliver Pinter wrote: > > On Monday, April 8, 2019, Warner Losh <i...@bsdimp.com> wrote: > > > >> > >> > >> On Sun, Apr 7, 2019, 3:16 PM Oliver Pinter > >> <oliver.pin...@hardenedbsd.org> > >> wrote: > >> > >>> Please revert this patch. If I'm not wrong, this will break the > >>> freebsd-version command's generation or output. > >>> > >> > >> You are going to need to be a lot more specific about this. It makes > >> no > >> sense to me at all how any of this could break that. The code is > >> identical > >> logically and produces the same result. > >> > > > > Now I double checked, it may work, but I remembered to this "black > > magic" : > > > https://github.com/freebsd/freebsd/blob/master/bin/freebsd-version/Makefile > > > > Given it will evaluate to > > BRANCH=${BRANCH_OVERRIDE:-CURRENT} > > which unless you set BRANCH_OVERRIDE, then it will still work no > problem. >
And if you set that, it will still work. :) However, this should be converted to VARS_ONLY. I'll do that. I've already done and, so will now grep the whole tree for similar constructs. Warner Chris > > -- > This message has been scanned for viruses and > dangerous content by MailScanner, and is > believed to be clean. > > _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
