Re: svn commit: r347984 - in head/sys: amd64/vmm/io arm/allwinner arm/allwinner/a10 arm/allwinner/clkng arm/arm arm/broadcom/bcm2835 arm/freescale/imx arm/mv arm/mv/armada arm/nvidia arm/nvidia/tegra12...

[Peter Jeremy]

On 2019-May-20 00:38:23 +0000, Conrad Meyer <c...@freebsd.org> wrote:
>Author: cem
>Date: Mon May 20 00:38:23 2019
>New Revision: 347984
>URL: https://svnweb.freebsd.org/changeset/base/347984
>
>Log:
>  Extract eventfilter declarations to sys/_eventfilter.h
...
>  No functional change (intended).  Of course, any out of tree modules that
>  relied on header pollution for sys/eventhandler.h, sys/lock.h, or
>  sys/mutex.h inclusion need to be fixed.  __FreeBSD_version has been bumped.

This seems to have broken at least netmap and netdump for me:
/usr/src/sys/dev/netmap/netmap_freebsd.c:191:3: error: implicit declaration of 
function 'EVENTHANDLER_REGISTER' is invalid in C99 
[-Werror,-Wimplicit-function-declaration]
                EVENTHANDLER_REGISTER(ifnet_arrival_event,
                ^
...
/usr/src/sys/netinet/netdump/netdump_client.c:1458:22: error: implicit 
declaration of function 'EVENTHANDLER_REGISTER' is invalid in C99 
[-Werror,-Wimplicit-function-declaration]
                nd_detach_cookie = EVENTHANDLER_REGISTER(ifnet_departure_event,
                                   ^

-- 
Peter Jeremy

signature.asc
Description: PGP signature