On Wed, May 29, 2019 at 08:56:23PM +0300, Andrey V. Elsukov wrote: A> On 29.05.2019 06:12, Gleb Smirnoff wrote: A> > A> bpf_mtap() is not the only consumer of bd_bif, some of them expect it A> > A> becomes NULL when descriptor is detached. A> > A> > May be then make a flag attached/detached? A> A> Do you have benchmark results that show some benefits in performance? :) A> I prefer to wait some time after MFC to get a bit wide testing, before A> doing another performance optimizations.
I was mostly motivated not by performance but by design, so that it conforms to delayed free architecture. Btw, now I see that my one liner isn't sufficient, since we bpfif_rele() not in the deferred context but right after CK_LIST_REMOVE(). -- Gleb Smirnoff _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
