On 4/20/19 9:32 AM, Enji Cooper wrote: > >> On Apr 20, 2019, at 9:31 AM, Enji Cooper <yaneurab...@gmail.com> wrote: >> >> >>> On Apr 20, 2019, at 9:30 AM, John Baldwin <j...@freebsd.org >>> <mailto:j...@freebsd.org>> wrote: >>> >>> On 4/20/19 8:43 AM, Enji Cooper wrote: >>>> Author: ngie >>>> Date: Sat Apr 20 15:43:28 2019 >>>> New Revision: 346443 >>>> URL: https://svnweb.freebsd.org/changeset/base/346443 >>>> <https://svnweb.freebsd.org/changeset/base/346443> >>>> >>>> Log: >>>> tests/sys/opencrypto: fix whitespace per PEP8 >>>> >>>> Replace hard tabs with four-character indentations, per PEP8. >>>> >>>> This is being done to separate stylistic changes from the tests from >>>> functional >>>> ones, as I accidentally introduced a bug to the tests when I used >>>> four-space >>>> indentation locally. >>>> >>>> No functional change. >>> >>> Wow, this is really painful for the 4-5 open reviews I have outstanding as >>> it >>> makes a merge disaster. >> >> Sorry ;_;… > > Being more constructive: I will back out the change, then reapply it > later. > Thank you,
Ok, is it easy to reapply using a script or some such? Also, in general I do prefer this indentation as 1) it works out of the box in emacs, and 2) many of the lines in cryptotest.py especially are indented pretty far over making it hard to read. -- John Baldwin _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
