Does not reproduce for me, dtrace says: # dtrace -n 'fbt::pgadjustjobc:entry { printf("pgrp %p count %d entering %d\n", args[0], args[0]->pg_jobc, arg1); }'
", args[0], args[0]->pg_jobc, arg1); }'dtrace: description 'fbt::pgadjustjobc:entry ' matched 1 probe CPU ID FUNCTION:NAME 0 12082 pgadjustjobc:entry pgrp fffff80083510e00 count 0 entering 1 6 12082 pgadjustjobc:entry pgrp fffff80002b6bc00 count 0 entering 1 0 12082 pgadjustjobc:entry pgrp fffff80083510e00 count 1 entering 0 0 12082 pgadjustjobc:entry pgrp fffff80002b6bc00 count 1 entering 0 I don't have time to dig into this one. If there are no takers, I'll replace these assertions with a comment. On 6/17/20, John Baldwin <j...@freebsd.org> wrote: > On 6/17/20 9:39 AM, Kyle Evans wrote: >> On Wed, Jun 17, 2020 at 10:21 AM Mateusz Guzik <mjgu...@gmail.com> wrote: >>> >>> pho@ reported triggering one of the asserts: >>> https://people.freebsd.org/~pho/stress/log/mjguzik028.txt >>> >>> I did not have the time to properly investigate this yet and this does >>> not reproduce for me. >>> >> >> Ah, this is good to know that he's reproduced it. There's only so many >> places that we touch these. I can't quite envision how, but the only >> scenario this would seem to be possible in is doenterpgrp() -> >> fixjobc(p, p->p_grp, 0) -> adjusts some child with a different process >> group without actually changing it, orphans the group, then we manage >> to finalize killjobc() on a freshly-orphaned process, which hasn't had >> its p_pgrp nullified. >> >> I haven't yet traced it through completely enough to determine if >> there's any way that can even happen. > > I reproduced it three times yesterday in a head VM by exiting GDB while > it was attached to a live process (which kills the process), something > like: > > gdb /bin/ls > start > ^D > > Should be enough to reproduce. > > -- > John Baldwin > -- Mateusz Guzik <mjguzik gmail.com> _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"