On Sun, Jan 1, 2012 at 12:33 PM, Ulrich Spoerlein <u...@freebsd.org> wrote: > On Fri, 2011-12-30 at 14:43:22 -0500, Ben Kaduk wrote: >> On Fri, Dec 30, 2011 at 5:58 AM, Ulrich Spoerlein <u...@freebsd.org> wrote: >> > Modified: head/usr.sbin/cron/doc/CHANGES >> > ============================================================================== >> > --- head/usr.sbin/cron/doc/CHANGES Fri Dec 30 10:45:00 2011 >> > (r228989) >> > +++ head/usr.sbin/cron/doc/CHANGES Fri Dec 30 10:58:14 2011 >> > (r228990) >> > @@ -1,3 +1,6 @@ >> > +$FreeBSD$ >> > +-------- >> > + >> > Vixie Cron Changes from V2 to V3 >> > Paul Vixie >> > 29-Dec-1993 >> > @@ -20,7 +23,7 @@ be reread whenever it changes. >> > >> > I also added a "-e" option to crontab(1). Nine people also sent me diffs >> > to add this option, but I had already implemented it on my own. I >> > actually >> > -released an interrim version (V2.2, I think) for limited testing, and got >> > a >> > +released an interim version (V2.2, I think) for limited testing, and got a >> >> Should we really be in the business of modifying Vixie's changelog? > > I'm replying here, but same goes for your comments on the other revision > (thanks for all those, btw). > > Warning, rant ahead:
I can handle a rant :) > > Our current SVN repo is in an inconsistent state thanks to the dubious > introduction of svn keywords. There are files in there, converted over > via cvs2svn and never touched since, but our presubmit checks want to > either see a $FreeBSD$ tag in modified files, or have fbsd:nokeywords > set. The latter is kinda a no-brainer for everything under contrib/ but > I'm struggling with what to do exactly for files that are non-contrib > and may or may not be non-code. Should the keywords be set on $subdir/* > or can I punch holes in the web of keywords as I see fit? (e.g. > $subdir/{README,CHANGES,foo.txt}) > > What's the point then anyway? SVN doesn't track files, but changesets. > Gah! I guess I did assume that the $FreeBSD$ keyword was being added because of the presubmit checks, but didn't actually say so. Sorry. It definitely is a grey area in which I don't presume to have an opinion, and I sympathize with your frustration. > > Oh wait, this ain't about the $FreeBSD$ keyword, but the typo-fix? I'm > sure that Vixie won't mind and do believe that correctness of spelling > is a worthy goal as we always tout the quality of our documentation. > I can accept that argument -- I mostly wanted to make sure this wasn't just a mechanical "run aspell over everything" or similar (though a later change did reveal that to not be the case). > FWIW, I'm not going to touch stuff under contrib/, etc. Sounds fine. > >> > /* >> > - * Delete a rotated logfiles, when using clasic filenames. >> > + * Delete a rotated logfiles, when using classic filenames. >> >> "a logfiles" is inconsistent. Without looking up the implementation, >> I'm going to guess that "a rotated logfile" is correct. > > When proofreading the spell-checked output I focused too narrowly on > just the typo that I fixed so that other typos in the same line/sentence > mostly went unnoticed. Will do better in the next couple of commits. It's easy to do -- I actually found myself also doing so a couple times when going through these. (There were quite a number of them, and thanks for going through them all by hand!) -Ben Kaduk _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"