...
>________________________________
>
>From: Konstantin Belousov
>
>...
>
>>
>> PR 137443
>From the PR, I fail to see what is the problem in our headers, and why
>the issue is not in some third-party C++ code.
>
>It is definitely has nothing to do with C++ name mangling.
>
Hmm.. yes, not a mangling issue but it is rather weird that it happens on C++.
Salome is not a toy app.
>>
>> > Although not very useful due to many other namespace
>> > pollution problems
>> > in the rpc headers, __rpc_xdr is in the
>> > implementation-reserved namespace,
>> > while XDR is not.
>> >
>>
>> The forced reference here is {Open}Solaris:
>>
>> http://src.illumos.org/source/xref/illumos-gate/usr/src/uts/common/rpc/xdr.h
>>
>> OpenGrok found no reference to __rpc_xdr
>> in OpenSolaris/illumos.
>I see, Solaris does
> typedef struct XDR { ... } XDR;
>and we now use the same trick.
>
>So my objections, if any, were against the commit message and not the actual
>code change then.
>
Quite definitely :( .. I mixed two different issues that I was trying to solve
(and one of them was not an issue at all). I will do a better job when I
MFC.
Thanks for checking though: I do feel nervous when touching a standard
header even if it's just to follow a change from upstream!
Pedro.
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
