Author: mjacob
Date: Mon Feb 25 14:06:24 2013
New Revision: 247266
URL: http://svnweb.freebsd.org/changeset/base/247266

Log:
  Don't try and negotiate sync mode if either period or offset are zero.
  
  PR:           kern/163064
  Partially Submitted by:       Peter <p...@citylink.dinoex.sub.org>
  MFC after:    1 month

Modified:
  head/sys/dev/sym/sym_hipd.c

Modified: head/sys/dev/sym/sym_hipd.c
==============================================================================
--- head/sys/dev/sym/sym_hipd.c Mon Feb 25 12:33:31 2013        (r247265)
+++ head/sys/dev/sym/sym_hipd.c Mon Feb 25 14:06:24 2013        (r247266)
@@ -8211,8 +8211,13 @@ static void sym_update_trans(hcb_p np, t
         *  Scale against driver configuration limits.
         */
        if (tip->width  > SYM_SETUP_MAX_WIDE) tip->width  = SYM_SETUP_MAX_WIDE;
-       if (tip->offset > SYM_SETUP_MAX_OFFS) tip->offset = SYM_SETUP_MAX_OFFS;
-       if (tip->period < SYM_SETUP_MIN_SYNC) tip->period = SYM_SETUP_MIN_SYNC;
+       if (tip->period && tip->offset) {
+               if (tip->offset > SYM_SETUP_MAX_OFFS) tip->offset = 
SYM_SETUP_MAX_OFFS;
+               if (tip->period < SYM_SETUP_MIN_SYNC) tip->period = 
SYM_SETUP_MIN_SYNC;
+       } else {
+               tip->offset = 0;
+               tip->period = 0;
+       }
 
        /*
         *  Scale against actual controller BUS width.
@@ -8231,21 +8236,23 @@ static void sym_update_trans(hcb_p np, t
        /*
         *  Scale period factor and offset against controller limits.
         */
-       if (tip->options & PPR_OPT_DT) {
-               if (tip->period < np->minsync_dt)
-                       tip->period = np->minsync_dt;
-               if (tip->period > np->maxsync_dt)
-                       tip->period = np->maxsync_dt;
-               if (tip->offset > np->maxoffs_dt)
-                       tip->offset = np->maxoffs_dt;
-       }
-       else {
-               if (tip->period < np->minsync)
-                       tip->period = np->minsync;
-               if (tip->period > np->maxsync)
-                       tip->period = np->maxsync;
-               if (tip->offset > np->maxoffs)
-                       tip->offset = np->maxoffs;
+       if (tip->offset && tip->period) {
+               if (tip->options & PPR_OPT_DT) {
+                       if (tip->period < np->minsync_dt)
+                               tip->period = np->minsync_dt;
+                       if (tip->period > np->maxsync_dt)
+                               tip->period = np->maxsync_dt;
+                       if (tip->offset > np->maxoffs_dt)
+                               tip->offset = np->maxoffs_dt;
+               }
+               else {
+                       if (tip->period < np->minsync)
+                               tip->period = np->minsync;
+                       if (tip->period > np->maxsync)
+                               tip->period = np->maxsync;
+                       if (tip->offset > np->maxoffs)
+                               tip->offset = np->maxoffs;
+               }
        }
 }
 
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to