On Nov 14, 2013, at 16:03 , Sergey Kandaurov <pluk...@freebsd.org> wrote:
> On 15 November 2013 00:07, George V. Neville-Neil <g...@freebsd.org> wrote: >> Author: gnn >> Date: Thu Nov 14 20:07:17 2013 >> New Revision: 258142 >> URL: http://svnweb.freebsd.org/changeset/base/258142 >> >> Log: >> Shift our OUI correctly. >> >> Pointed out by: emaste >> >> Modified: >> head/sys/net/ieee_oui.h >> >> Modified: head/sys/net/ieee_oui.h >> ============================================================================== >> --- head/sys/net/ieee_oui.h Thu Nov 14 19:53:35 2013 (r258141) >> +++ head/sys/net/ieee_oui.h Thu Nov 14 20:07:17 2013 (r258142) >> @@ -62,5 +62,5 @@ >> */ >> >> /* Allocate 64K to bhyve */ >> -#define OUI_FREEBSD_BHYVE_LOW OUI_FREEBSD + 0x000001 >> -#define OUI_FREEBSD_BHYVE_HIGH OUI_FREEBSD + 0x00ffff >> +#define OUI_FREEBSD_BHYVE_LOW ((OUI_FREEBSD << 3) + 0x000001) >> +#define OUI_FREEBSD_BHYVE_HIGH ((OUI_FREEBSD << 3) + 0x00ffff) > > Shouldn't it be rather shifted with 24 (3 x 8bits)? Correct, and it should really be an | not a +. I’ll commit a fix. Best, George
signature.asc
Description: Message signed with OpenPGP using GPGMail