On Sun, Dec 1, 2013 at 6:07 PM, Jilles Tjoelker <jil...@stack.nl> wrote:
>> Revert the drm2/i915 changes from this and following commits now. >> You did not contacted obvious maintainer of the file. Of course I did not. This was discussed on arch@ and the change made mechanically. >> The changes are pointless and make the import of upstream changes >> harder; for i915_reg.h, much harder. > > This is a valid concern. The change should be submitted to upstream; if > upstream does not want the change, it is better to avoid the issue by > adding -fno-strict-overflow for the offending files, matching upstream. I will revert to the broken and incorrect code in sys/dev/drm2/i915. Upstream should be contacted with the patch. >> Not to mention that the whole churn is not needed if the >> -fno-strict-overflow flag is used. > > I think the undefined shifts should be fixed where possible and not in > contributed code. Agreed. In addition, contributed code ought to be clearly differentiated in the directory hierarchy. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
