On 9/24/2014 8:38 AM, John Baldwin wrote: > On Tuesday, September 23, 2014 05:04:21 PM Bryan Drewery wrote: >> Author: bdrewery >> Date: Tue Sep 23 17:04:21 2014 >> New Revision: 272032 >> URL: http://svnweb.freebsd.org/changeset/base/272032 >> >> Log: >> DEBUG_LOCKS no longer modifies 'struct vnode', nor does fstat(1) use it. >> fstat(1) now uses libprocstat(9). There is no userland impact to using >> this. > > As your followup noted, it does change the size of 'struct lock' (and thus > 'struct vnode') still. While fstat does not use it for live, it probably > still uses it for coredumps. However, lsof uses kvm access, so it will break. > I don't think that is worth noting here, but more of an FYI. >
Hmm, I see my commit logs were not fully accurate. I was too focused on the stale comment about fstat(1). -- Regards, Bryan Drewery
signature.asc
Description: OpenPGP digital signature