On Oct 31, 2014, at 17:51, Dag-Erling Smørgrav <d...@des.no> wrote: > Xin LI <delp...@freebsd.org> writes: >> Log: >> rc.d/geli should not depend on random, as the attach functionality >> do not require additional entropy to function. >> >> It would create a circular dependency (not immediately obvious: >> geli provides 'disks' and requires 'random' as of r273872, >> 'random' requires 'FILESYSTEMS', 'FILESYSTEMS' requires 'root', >> 'root' requires 'swap', and finally 'swap' requires 'disk'). > > My first instinct was: shouldn't rcorder warn about this? It turns out > that it does, but in a very cryptic fashion: > > des@nine ~head/etc/rc.d% svn up -qr273871 > des@nine ~head/etc/rc.d% rcorder * >/dev/null > des@nine ~head/etc/rc.d% svn up -qr273872 > des@nine ~head/etc/rc.d% rcorder * >/dev/null > rcorder: Circular dependency on file `zfs'. > rcorder: Circular dependency on provision `mountcritlocal' in file `zfs'. > rcorder: Circular dependency on provision `mountcritlocal' in file `var'. > rcorder: Circular dependency on provision `mountcritlocal' in file > `FILESYSTEMS'. > rcorder: Circular dependency on provision `root' in file `FILESYSTEMS'. > des@nine ~head/etc/rc.d% svn up -qr273919 > des@nine ~head/etc/rc.d% rcorder * >/dev/null > des@nine ~head/etc/rc.d%
rcorder errors are indeed cryptic/confusing. I can quickly add a testcase for this if you like (basically check for all the scenarios that need to be covered via /etc/rc). Does that sound good? Thanks!
signature.asc
Description: Message signed with OpenPGP using GPGMail
