On 08/11/2014 19:00, Alexander Kabaev wrote: > On Thu, 6 Nov 2014 22:46:40 +0000 (UTC) Mark Johnston <ma...@freebsd.org> > wrote: > >> Author: markj Date: Thu Nov 6 22:46:40 2014 New Revision: 274200 URL: >> https://svnweb.freebsd.org/changeset/base/274200 >> >> Log: Automatically build with debug symbols when building with WITH_CTF. >> Otherwise there's nothing for ctfconvert to do, and it ends up emitting >> an error for each object file. Also remove some redundant checks from >> bsd.prog.mk and bsd.lib.mk. > <SKIP> >> >> -.if ${MK_CTF} != "no" && ${DEBUG_FLAGS:M-g} != "" +.if ${MK_CTF} != >> "no" CTFFLAGS+= -g .endif .else > > I have a question about this and another similar change. Does it have the > effect of always leaving binaries with debug symbols in id WITH_CTF is in > effect and do we now rely solely on install stripping binaries at later > stage to get rid of the debug symbols? IMHO, we should only pass -g to > ctfconvert if WITH_CTF is set _and_ user requested debug symbols > explicitly. Your change seems to be breaking that.
Hmm, I do not follow your logic here, sorry. So, you say that stripping should be ctfconvert's job? Why? -- Andriy Gapon _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"