On Wed, 24 Dec 2014 18:05:47 -0800 Rui Paulo <rpa...@me.com> wrote: > On Dec 24, 2014, at 17:31, Ian Lepore <i...@freebsd.org> wrote: > > In every architecture and every place it's used, or just arm just > > here? > > You're right, it can be found at least in MIPS and amd64. > > > This appears to be an idiom, or at least something that has been > > pasted in identical form in every arch so far. > > The idiom is a bit different in amd64: the variable in the for-loop > isn't immediately reused, but it's a global variable anyway... > That's what I thought deserves a comment.
I agree we should add a comment here. It's non-obvious the functions will return the same value across multiple calls. > Regarding the pmap_kenter_temporary(), the first problem is the > function name: it might be a temporary mapping, but the real use is > for crash dumps (I wonder why ACPI abuses this mapping). The other > problem is the fact that a pmap function is so tied to crash dumps. > However, that's a bigger problem. Yes, this functions looks like it needs to be reworked a little but I would have to think about it first. Andrew _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
