> On Jan 20, 2015, at 12:35 AM, Hans Petter Selasky <h...@selasky.org> wrote:
> 
> On 01/20/15 06:22, Adrian Chadd wrote:
>> Sweet, thanks. I'l test it, but anything that changes the locking to
>> TCP is going to need a more thorough review. The "there be dragons"
>> disclaimer is appropriate.:)
> 
> No changes in locking - simply some minor code reordering.

This isn’t entirely true. You changed the INFO_WLOCK protocol, and also drop 
the WLOCK to acquire the INFO_WLOCK in places, and it isn’t clear to me at all 
why this is safe to do. Please document the analysis you did to show that was 
safe.

Warner

_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to