On 29 Jan 2015, at 09:23, John-Mark Gurney <j...@funkthat.com> wrote: > > Dimitry Andric wrote this message on Wed, Jan 28, 2015 at 22:22 +0000: >> Replace the VERSION_KEY define with a writable char array, so no const >> qualifier needs to be dropped anymore. > > You do realize that you should juse use __DECONST for this instead? > > This moves the data from .rodata into .data making it writable, and > also means that bad programs could end up stop working, instead of > faulting when someone tries to change the version string...
I don't see the risk here, the db api does not actually modify the incoming key (the API is just badly designed). But if you think it is nicer to use __DECONST, feel free to change it. -Dimitry
signature.asc
Description: Message signed with OpenPGP using GPGMail
