> On Aug 28, 2015, at 00:24, O'Connor, Daniel <dar...@dons.net.au> wrote: > >> On 28 Aug 2015, at 15:34, Alexey Dokuchaev <da...@freebsd.org> wrote: >>> On Thu, Aug 27, 2015 at 10:25:28PM -0700, NGie Cooper wrote: >>>> On Thu, Aug 27, 2015 at 9:43 PM, Alexey Dokuchaev <da...@freebsd.org> >>>> wrote: >>>>> On Fri, Aug 28, 2015 at 12:44:59AM +0000, Xin LI wrote: >>>>> New Revision: 287236 >>>>> URL: https://svnweb.freebsd.org/changeset/base/287236 >>>>> >>>>> Log: >>>>> Use exit() instead of return in main(). >>>> >>>> Because?.. >>> >>> Probably because of libxo... >> >> I'm just wondering how hard is it to write sensible commit logs. :( > > To put it in a hopefully more helpful way.. > Please write why your change is doing something, not what it is doing. > > Saying what it is doing is OK if it's really hairy, but 99% of the time that > isn't the case. > > Assuming this is a libxo thing the commit log should have been something > like.. > "Use exit out of main otherwise libxo will not flush properly" > (or something similar) > > Although it would be surprising if libxo required you to use exit()..
Libxo (iirc) doesn't install atexit handlers, which means that you need to use exit (or a reason facsimile) in order for it to flush its file streams. This is unintuitive though. I wish it did the right thing as part of initializing the streams.. _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
