On 8 Oct 2015, at 13:51, Andriy Gapon <a...@freebsd.org> wrote: > > What if one day github disappears but FreeBSD is still going? > The full commit message would be lost.
That’s not the only thing that is bad about this commit message. Why ‘Assume C89?’ We compile libc as C99 + GNU extensions and are likely to default to C11 + GNU extensions soon. Reading the actual commit, it looks as if it’s changing K&R declarations to ISO C declarations. It’s also introducing an ATTRIBUTE_PURE macro in private.h, which does exactly the same as __pure declared in sys/cdefs.h (which is included by *every single FreeBSD header*. Why this extra spelling? No idea. Is this contrib code (it looks like it)? If so, it should come in via the vendor area (not be directly committed to head), if not then it should have been code reviewed and not include redundant and confusing macro declarations. When merging stuff from GitHub, Alfred has written some good documentation about how to handle them in such a way that we preserve the prior commit history (effectively, checkout the pr branch, rebase it on head, git svn dcommit the result). Please follow this procedure. David _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
