On 10/21/2015 8:56 AM, Hans Petter Selasky wrote:
> On 10/21/15 17:42, Bryan Drewery wrote:
>> On 10/21/2015 8:39 AM, Hans Petter Selasky wrote:
>>> On 10/21/15 17:28, Bryan Drewery wrote:
>>>> On 10/21/2015 8:01 AM, Hans Petter Selasky wrote:
>>>>> Author: hselasky
>>>>> Date: Wed Oct 21 15:01:51 2015
>>>>> New Revision: 289700
>>>>> URL: https://svnweb.freebsd.org/changeset/base/289700
>>>>>
>>>>> Log:
>>>>>     Start process of moving the LinuxKPI into the default kernel
>>>>> build by
>>>>>     creating an empty directory tree.
>>>>>
>>>>>     Sponsored by:    Mellanox Technologies
>>>>>
>>>>> Added:
>>>>>     head/sys/compat/linuxkpi/
>>>>>     head/sys/compat/linuxkpi/common/
>>>>>     head/sys/compat/linuxkpi/common/include/
>>>>>     head/sys/compat/linuxkpi/common/include/asm/
>>>>>     head/sys/compat/linuxkpi/common/include/linux/
>>>>>     head/sys/compat/linuxkpi/common/src/
>>>>>
>>>>
>>>> This makes me think a branch should be used instead.
>>>>
>>>
>>> Most of what will be done is "svn mv" out of "sys/ofed" and changing
>>> some include paths in sys/modules and sys/conf . Can you explain why you
>>> think a branch is required ?
>>
>> Because you're splitting commits up that should otherwise not be split
>> up. There's no reason to commit empty directories before a 'svn mv' into
>> them.
> 
> OK, I see. Do you want me to revert the "svn add" and put it altogether
> in a single commit, or is not not that big deal if I keep the next
> linuxkpi file moving as a single commit?

No, it's fine. I just didn't want to see subsequent partial commits that
broke the tree.


-- 
Regards,
Bryan Drewery

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to