On 11/6/2015 12:43 AM, Garrett Cooper wrote: > Author: ngie > Date: Fri Nov 6 08:43:12 2015 > New Revision: 290437 > URL: https://svnweb.freebsd.org/changeset/base/290437 > > Log: > Fix compiling netstat after r290367 by substituting sys/types.h for > sys/param.h, as sys/param.h defines the MAX(..) macro > > Reported by: O. Hartmann <ohart...@zedat.fu-berlin.de> > Pointyhat to: ume > > Modified: > head/usr.bin/netstat/if.c > > Modified: head/usr.bin/netstat/if.c > ============================================================================== > --- head/usr.bin/netstat/if.c Fri Nov 6 05:32:18 2015 (r290436) > +++ head/usr.bin/netstat/if.c Fri Nov 6 08:43:12 2015 (r290437) > @@ -37,7 +37,7 @@ static char sccsid[] = "@(#)if.c 8.3 (Be > #include <sys/cdefs.h> > __FBSDID("$FreeBSD$"); > > -#include <sys/types.h> > +#include <sys/param.h> > #include <sys/protosw.h> > #include <sys/socket.h> > #include <sys/socketvar.h> >
This is strange, it was building fine for days, and builds fine for me locally with reverting this change. While this may be proper, how is this a 'fix compiling' and a 'pointyhat'? -- Regards, Bryan Drewery
signature.asc
Description: OpenPGP digital signature