On 1/19/2016 9:40 AM, Bryan Drewery wrote: > On 1/19/2016 8:13 AM, Bryan Drewery wrote: >> On 1/19/2016 5:56 AM, Dag-Erling Smørgrav wrote: >>> Bryan Drewery <[email protected]> writes: >>>> Log: >>>> Replace unneeded manual dependency on header by adding it to SRCS. >>>> >>>> bsd.lib.mk and bsd.prog.mk already depend all objs on headers in SRCS if >>>> there is not yet a depend file. The headers in SRCS are never built or >>>> installed. After 'make depend' the header was already added as a proper >>>> dependency on the objects where needed. >>> >>> This doesn't work. Try the following: >>> >>> $ cd /usr/src/secure/lib/libssh >>> $ make depend && make >>> $ touch /usr/src/crypto/openssh/ssh_namespace.h >>> $ make >> >> Well, it sort of works with WITH_FAST_DEPEND which will be default very >> shortly. >> > ... >>> $ grep -c ssh_namespace $(make -V.OBJDIR)/.depend >>> 0 >>> >> >> That is expected. The dependency is defined in bsd.lib.mk. Granted it is >> dependent on .depend existing, but I am going to remove that check so it >> is always defined. >> > > The problem with the old method (mkdep which is still default) is that > the -include is not passed to mkdep. FAST_DEPEND does not have that > issue since it generates the .depend files during compilation, where the > -include is present. > >
It's manifesting for people now with -DNO_CLEAN using mkdep. I'm working on a solution rather than reverting. /usr/obj/usr/src/tmp/usr/lib/libprivatessh.so: undefined reference to `Fssh_crypto_scalarmult_curve25519' -- Regards, Bryan Drewery
signature.asc
Description: OpenPGP digital signature
