Hi,

It looks like this change breaks boot on my machine.
I’m running a root-on-ZFS system and reliably see this panic during boot. It’s a 4 disk raidz-1.

It’s now running r302028 with r300881 backed out, and booting fine.

The panic:
panic: solaris assert: refcount(count(&spa->spa_refcount) >= spa->spa_minref || MUTEX_HELD(&spa_namespace_lock), file: /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c, line: 863

Unfortunately I can’t get a dump, but here’s a picture of the backtrace:
https://people.freebsd.org/~kp/zfs_panic.jpg


Regards,
Kristof

On 28 May 2016, at 0:32, Alan Somers wrote:

Author: asomers
Date: Fri May 27 22:32:44 2016
New Revision: 300881
URL: https://svnweb.freebsd.org/changeset/base/300881

Log:
Avoid issuing spa config updates for physical path when not necessary

ZFS's configuration needs to be updated whenever the physical path for a device changes, but not when a new device is introduced. This is because new devices necessarily cause config updates, but only if they are actually
  accepted into the pool.

  sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c
        Split vdev_geom_set_physpath out of vdev_geom_attrchanged.  When
        setting the vdev's physical path, only request a config update if
        the physical path has changed.  Don't request it when opening a
        device for the first time, because the config sync will happen
        anyway upstack.

  sys/geom/geom_dev.c
        Split g_dev_set_physpath and g_dev_set_media out of
        g_dev_attrchanged

  Submitted by: will, asomers
  MFC after:    4 weeks
  Sponsored by: Spectra Logic Corp
  Differential Revision:        https://reviews.freebsd.org/D6428

Modified:
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c
  head/sys/geom/geom_dev.c
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to